Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8200364

Remove unnecessary boxing via primitive wrapper valueOf(String) methods

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P3 P3
    • 11
    • None
    • core-libs
    • None
    • b08

      A colleague used findbugs to find these small fixes to useless boxing:

      diff --git a/src/java.base/share/classes/java/text/ChoiceFormat.java b/src/java.base/share/classes/java/text/ChoiceFormat.java
      --- a/src/java.base/share/classes/java/text/ChoiceFormat.java
      +++ b/src/java.base/share/classes/java/text/ChoiceFormat.java
      @@ -212,7 +212,7 @@
                       } else if (tempBuffer.equals("-\u221E")) {
                           startValue = Double.NEGATIVE_INFINITY;
                       } else {
      - startValue = Double.valueOf(tempBuffer);
      + startValue = Double.parseDouble(tempBuffer);
                       }
       
                       if (ch == '<' && startValue != Double.POSITIVE_INFINITY &&
      diff --git a/src/java.logging/share/classes/java/util/logging/Logger.java b/src/java.logging/share/classes/java/util/logging/Logger.java
      --- a/src/java.logging/share/classes/java/util/logging/Logger.java
      +++ b/src/java.logging/share/classes/java/util/logging/Logger.java
      @@ -640,7 +640,7 @@
                           return System.getProperty(key);
                       }
                   });
      - return Boolean.valueOf(s);
      + return Boolean.parseBoolean(s);
               }
           }
       

            martin Martin Buchholz
            martin Martin Buchholz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: