-
Bug
-
Resolution: Fixed
-
P3
-
9, 10, 11
-
b18
-
generic
-
os_x
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8205260 | 11.0.1 | Sergey Bylokhov | P3 | Resolved | Fixed | team |
A colleague reports that
self == [super init]
makes no sense in CFileDialog.m
citing
https://www.cocoawithlove.com/2009/04/what-does-it-mean-when-you-assign-super.html
and suggests
src/java.desktop/macosx/native/libawt_lwawt/awt/CFileDialog.m
@@ -46,7 +46,7 @@
canChooseDirectories:(BOOL)inChooseDirectories
withEnv:(JNIEnv*)env;
{
- if (self == [super init]) {
+ if (self = [super init]) {
fHasFileFilter = inHasFilter;
fFileDialog = JNFNewGlobalRef(env, inDialog);
fDirectory = inPath;
self == [super init]
makes no sense in CFileDialog.m
citing
https://www.cocoawithlove.com/2009/04/what-does-it-mean-when-you-assign-super.html
and suggests
src/java.desktop/macosx/native/libawt_lwawt/awt/CFileDialog.m
@@ -46,7 +46,7 @@
canChooseDirectories:(BOOL)inChooseDirectories
withEnv:(JNIEnv*)env;
{
- if (self == [super init]) {
+ if (self = [super init]) {
fHasFileFilter = inHasFilter;
fFileDialog = JNFNewGlobalRef(env, inDialog);
fDirectory = inPath;
- backported by
-
JDK-8205260 [macos] Nonsensical self == [super init] in CFileDialog.m
-
- Resolved
-
- links to