Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8205058

(fs) Files read/writeString should throw CharacterCodingException instead of IOException with an IllegalArgumentException as cause

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 11
    • 11
    • core-libs
    • b20
    • Verified

    Backports

      Description

        Files read/writeString implementation could be cleaner if it throws CharacterCodingException instead of an IOException with an IllegalArgumentException as cause for the malformed or unmappable cases.

        The code can be cleaner with an import of jdk.internal.misc.JavaLangAccess rather than repeating the fully qualified class name. The definition of JLA can be moved up to the top. There's also a few inconsistencies with the existing code that would be good to fix (indenting and line length issues mostly).

        The test looks reasonable. In getData() then then "shouldn't happen" case should throw an exception as a NPE here might be tricky to diagnose there. Another nit is the sb field - can that be removed.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8206604 (fs) Files read/writeString should throw CharacterCodingException instead of IOException with an IllegalArgumentException as cause

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8206827 (fs) Files read/writeString should throw CharacterCodingException instead of IOException with an IllegalArgumentException as cause

            • P3 - Major loss of function.
            • Resolved
            relates to

            Sub-task - The sub-task of the issue JDK-8201276 (fs) Add methods to Files for reading/writing a string from/to a file

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8205613 (cs) MalformedInputException and UnmappableCharacterException need offset value

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Open

            Activity

              People

                joehw Joe Wang
                joehw Joe Wang
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: