Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8205648

fix for 8205195 breaks secondary error handling

XMLWordPrintable

    • b20
    • generic
    • generic

        Thanks to the eagle eyes of David Holmes for spotting
        this bug in a post-push code review!

        The fix for 8205195 added a grab of the Threads_lock
        in controlled_crash() to make the ErrorHandling tests
        more stable. However, this lock grab did not take into
        account that controlled_crash() could be called
        recursively as part of:

        test/hotspot/jtreg/runtime/ErrorHandling/SecondaryErrorTest.java

        This results in the test having a secondary crash due to a
        recursive Threads_lock grab instead of the intended secondary
        failure (a SIGSEGV).

        Unfortunately, it is very, very difficult to verify the reason for a
        secondary failure so SecondaryErrorTest.java does not fail
        with the fix for 8205195 in place in any obvious way.

              dcubed Daniel Daugherty
              dcubed Daniel Daugherty
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: