Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8209670

CompilerThread releasing code buffer in destructor is unsafe

    XMLWordPrintable

Details

    • 11
    • b28

    Backports

      Description

        I believe it is unsafe for CompilerThread to release code buffer in its destructor.

        Before CompilerThread reaches its destructor, it has to be removed from Threads list, which made it no longer participates safepoints. It opens up a race window that can result safepoint scanning to stumble over the code buffer just deleted by CompilerThread's destructor.

        Although, the destructor takes CodeCache_lock, but safepoint walk does not take this lock, so it is a race.

        I have seen this problem during Shenandoah tests on a big machine with many cores.



        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8210075 CompilerThread releasing code buffer in destructor is unsafe

            • P1 - Blocks development and/or testing work, production could not run.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8210083 CompilerThread releasing code buffer in destructor is unsafe

            • P1 - Blocks development and/or testing work, production could not run.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8210174 CompilerThread releasing code buffer in destructor is unsafe

            • P1 - Blocks development and/or testing work, production could not run.
            • Resolved
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8209767 gc/parallel/TestPrintGCDetailsVerbose.java failed with assert in CodeCache::verify_icholder_relocations()

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8205499 C1 temporary code buffers are not removed with -XX:+UseDynamicNumberOfCompilerThreads

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Enhancement - null JDK-8198756 Lazy allocation of compiler threads

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Activity

              People

                thartmann Tobias Hartmann
                zgu Zhengyu Gu
                Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: