Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8211958

Broken links in java.desktop files

XMLWordPrintable

    • b23

      A link checker has uncovered various broken links.

      The following entries in DesktopProperties.java need to be adjusted to refer to a class in a sibling module:
      $ find open/src -name DesktopProperties.html | xargs grep -E '\.\./(java|io|lang|net|util)'
      <td valign="TOP"><a href="../../util/Map.html">java.util.Map</a></td>
      <td valign="TOP"><a href="../../lang/Boolean.html">java.lang.Boolean</a></td>
      <a href="../../../javax/swing/JComponent.html"> Swing components</a> which
      <a href="../../util/Map.html"> Map</a> of

      The following list is for relative links in java.awt *.java files. Most are "warnings', one is an error:
      $ grep -r '\.\./java' open/src/java.desktop/share/classes/java/awt
      open/src/java.desktop/share/classes/java/awt/DefaultFocusTraversalPolicy.java: * <a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/Container.java: * <a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/Font.java: * href="../../java/lang/Character.html#supplementary"> supplementary
      open/src/java.desktop/share/classes/java/awt/DefaultKeyboardFocusManager.java: * <a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/KeyboardFocusManager.java: * <a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/doc-files/DesktopProperties.html:<a href="../../../javax/swing/JComponent.html"> Swing components</a> which
      open/src/java.desktop/share/classes/java/awt/Component.java: * <a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/Component.java: *<a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/Component.java: *<a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/Component.java: *<a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      open/src/java.desktop/share/classes/java/awt/FocusTraversalPolicy.java: * <a href="../../java/awt/doc-files/FocusSpec.html">Focus Specification</a>
      The third entry, the reference to java/lang/Character needs an extra ../java.base to be inserted.
      The other entries are not wrong, but they could all be simplified by removing ../../java/awt

      This line in FontMetrics.java needs to be updated with a ../java.base
      open/src/java.desktop/share/classes/java/awt/FontMetrics.java: * href="../lang/Character.html#supplementary"> supplementary

      This list is for links in javax.imagio: entries for DataInput and Iterator need cross-module updates
      $ grep -r '\.\./\(java\|lang\)' $(find open/src -name imageio)
      open/src/java.desktop/share/classes/javax/imageio/stream/ImageOutputStream.java: * <a href="../../../java/io/DataInput.html#modified-utf-8">modified
      open/src/java.desktop/share/classes/javax/imageio/stream/ImageInputStream.java: * <a href="../../../java/io/DataInput.html#modified-utf-8">modified
      open/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/tiff_metadata.html:<li>Create an <a href="../../../../java/awt/color/ICC_ColorSpace.html">
      open/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/tiff_metadata.html:<a href="../../../../java/awt/color/ICC_Profile.html">
      open/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/tiff_metadata.html:<a href="../../../../java/util/Iterator.html">Iterator</a> returned by
      open/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/tiff_metadata.html:<li>the <a href="../../../../java/awt/color/ColorSpace.html">ColorSpace</a>

      These references in DocFlavor.java need updating:
      $ find open/src -name DocFlavor.java | xargs grep 'package-summary' /dev/null
      open/src/java.desktop/share/classes/javax/print/DocFlavor.java: * <a href="../../java/lang/package-summary.html#charenc">character encodings
      open/src/java.desktop/share/classes/javax/print/DocFlavor.java: * See <a href="../../java/lang/package-summary.html#charenc">character

      This reference in a package-info needs fixing
      $ grep -F ../java open/src/java.desktop/share/classes/javax/print/attribute/package-info.java /dev/null
      open/src/java.desktop/share/classes/javax/print/attribute/package-info.java: * <a href="../../../java/util/Map.html">Map</a> interface: it provides a map of

            serb Sergey Bylokhov
            jjg Jonathan Gibbons
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: