- 
    Type:
Enhancement
 - 
    Resolution: Fixed
 - 
    Priority:
  P4                     
     - 
    Affects Version/s: 12
 - 
    Component/s: hotspot
 
- 
        b08
 
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build | 
|---|---|---|---|---|---|---|
| JDK-8297206 | 17.0.7-oracle | PAWAN CHAWDHARY | P4 | Resolved | Fixed | b01 | 
| JDK-8299577 | 17.0.7 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 | 
                    The native code for these tests is quite problematic and could do with a lot of clean up.
On the "quality of implementation" side we should:
- replace unchecked malloc calls with the c_malloc function introduced byJDK-8210242
- stop assuming the strings returned from GetString*Chars are NUL-terminated (they are in hotspot but that's not required by the spec)
On the hotspot-style side:
- add spaces around operators, in argument lists, etc
- add indentation that is missing in many places
- add braces to if-blocks
- fix misuses of CE (check exception) macro, and remove unnecessary explicit exception checking
            
On the "quality of implementation" side we should:
- replace unchecked malloc calls with the c_malloc function introduced by
- stop assuming the strings returned from GetString*Chars are NUL-terminated (they are in hotspot but that's not required by the spec)
On the hotspot-style side:
- add spaces around operators, in argument lists, etc
- add indentation that is missing in many places
- add braces to if-blocks
- fix misuses of CE (check exception) macro, and remove unnecessary explicit exception checking
- backported by
 - 
                    
JDK-8297206 [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup
-         
     - Resolved
 
 -         
 - 
                    
JDK-8299577 [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup
-         
     - Resolved
 
 -         
 
- relates to
 - 
                    
JDK-8210242 [TESTBUG] vmTestbase/nsk/stress/jni/jnistress001.java crashes with EXCEPTION_ACCESS_VIOLATION on windows-x86
-         
     - Resolved
 
 -         
 
- links to
 - 
                    
        
        Commit
        openjdk/jdk17u-dev/bd58dd82
    
 - 
                    
        
        Commit
        openjdk/jdk/fde18313
    
 - 
                    
        
        Review
        openjdk/jdk17u-dev/1010
    
 - 
                    
        
        Review
        openjdk/jdk/4882
    
 
             (2 links to)