Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8212961

[TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup

    XMLWordPrintable

Details

    • b08

    Backports

      Description

        The native code for these tests is quite problematic and could do with a lot of clean up.

        On the "quality of implementation" side we should:

        - replace unchecked malloc calls with the c_malloc function introduced by JDK-8210242
        - stop assuming the strings returned from GetString*Chars are NUL-terminated (they are in hotspot but that's not required by the spec)

        On the hotspot-style side:
        - add spaces around operators, in argument lists, etc
        - add indentation that is missing in many places
        - add braces to if-blocks
        - fix misuses of CE (check exception) macro, and remove unnecessary explicit exception checking

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8297206 [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299577 [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8210242 [TESTBUG] vmTestbase/nsk/stress/jni/jnistress001.java crashes with EXCEPTION_ACCESS_VIOLATION on windows-x86

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/bd58dd82

            Commit Commit openjdk/jdk/fde18313

            Review Review openjdk/jdk17u-dev/1010

            Review Review openjdk/jdk/4882

            Activity

              People

                dholmes David Holmes
                dholmes David Holmes
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: