Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8213035

Pack MethodHandleInlineStrategy coder and length into a long

    XMLWordPrintable

Details

    Backports

      Description

        Packing the coder and length into a long allows us to generate fewer intermediary method handles for indified String concat expressions. Theoretically close to a third less for concatenation of non-constant-String, Object and char.

        Care had to be taken to ensure the JITs are as good to optimize the resulting MH, and microbenchmarks show that C2 is as good to optimize the new code. Sometimes a few instructions better, sometimes a few instructions worse.

        Attached benchmark and results show that when running in interpreted mode the patch is significantly faster (the overhead of calling more combiners and methods outweigh the extra cost of unpacking coder and length), while in C1 there is a similar slowdown.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8319603 Pack MethodHandleInlineStrategy coder and length into a long

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8322270 Pack MethodHandleInlineStrategy coder and length into a long

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8320045 Pack MethodHandleInlineStrategy coder and length into a long

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8320406 StringConcat.java has duplicate methods added as part of JDK-8212726

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8297530 java.lang.IllegalArgumentException: Negative length on strings concatenation

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Activity

              People

                redestad Claes Redestad
                redestad Claes Redestad
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: