Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8214444

Wrong strncat limits in dfa.cpp

    XMLWordPrintable

Details

    • b23

    Backports

      Description

        GCC 8 reports errors like:

        src/hotspot/share/adlc/dfa.cpp:724:14: error: 'char* strncat(char*, const char*, size_t)' specified bound 2048 equals destination size [-Werror=stringop-overflow=]
               strncat(string_buffer, "+", STRING_BUFFER_LENGTH);

        Both GCC 8 and static check tools can be satisfied by carefully switching from strncat to snprintf.
        It would be nice to use jio_snprintf but adlc should not depend on VM.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8243352 Wrong strncat limits in dfa.cpp

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8243958 Wrong strncat limits in dfa.cpp

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Task - A task that needs to be done. JDK-8213153 Clean up GCC 8 errors

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8207049 Minor improvements of compiler code.

            • P3 - Major loss of function.
            • Resolved

            Activity

              People

                dchuyko Dmitry Chuyko
                dchuyko Dmitry Chuyko
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: