Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8214777

Avoid some GCC 8.X strncpy() errors in HotSpot

    XMLWordPrintable

Details

    • b10

    Backports

      Description

        Gcc 8 has strict (and sometimes buggy) tests for strncpy() misuse.

        A common pattern in the JDK is:

            const size_t not_impl_len = strlen(not_impl);
            *str = NEW_C_HEAP_ARRAY(char, not_impl_len+1, mtTracing);
            strncpy(*str, not_impl, not_impl_len);
            (*str)[not_impl_len] = '\0';

        More efficient code that does not cause GCC warnings would use strncpy()
        to add the trailing null, resulting in shorter code:

             strncpy(*str, not_impl, not_impl_len);
            (*str)[not_impl_len] = '\0';

        becomes:

            strncpy(*str, not_impl, not_impl_len+1);

        (found by compiling with GCC 8.1)

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8230177 Avoid some GCC 8.X strncpy() errors in HotSpot

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8304299 Avoid some GCC 8.X strncpy() errors in HotSpot

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8205201 Problematic strncpy usage causes compiler warning on Fedora 28

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8219583 Windows build failure after JDK-8214777 (Avoid some GCC 8.X strncpy() errors in HotSpot)

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8214776 Avoid GCC 8.X strncpy() errors in JFR code

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Task - A task that needs to be done. JDK-8213153 Clean up GCC 8 errors

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Enhancement - null JDK-8232187 Add os::strncpy_s

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Open

            Activity

              People

                mikael Mikael Vidstedt
                sgehwolf Severin Gehwolf
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: