Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8215443

The use of TransportContext.fatal() leads to bad coding style

    XMLWordPrintable

Details

    Backports

      Description

        The TransportContext.fatal() always throw exception. The code that use the method looks a little bit unusual:

             shc.conContext.fatal(Alert.UNEXPECTED_MESSAGE, "...");
             return null; // make the complier happy

        The return statement is never get executed. However, if remove the return statement, the compiler may not happy with it, or the code reader will continue read more of the code and lead to confusing logic.

        Maybe, using throw statement directly could be an alternative improvement:
        - shc.conContext.fatal(Alert.UNEXPECTED_MESSAGE, "...");
        - return null; // make the complier happy
        + throw shc.conContext.fatal(Alert.UNEXPECTED_MESSAGE, "...");

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8215671 The use of TransportContext.fatal() leads to bad coding style

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8216101 The use of TransportContext.fatal() leads to bad coding style

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8220572 The use of TransportContext.fatal() leads to bad coding style

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8245155 The use of TransportContext.fatal() leads to bad coding style

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8245156 The use of TransportContext.fatal() leads to bad coding style

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8251756 The use of TransportContext.fatal() leads to bad coding style

            • P3 - Major loss of function.
            • Resolved
            relates to

            Sub-task - The sub-task of the issue JDK-8196584 TLS 1.3 Implementation

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Activity

              People

                xuelei Xuelei Fan
                xuelei Xuelei Fan
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: