On 31/12/2018 4:00 am, Sergei Ustimenko wrote:> Hi,
>
> I was looking through hsdis documentation to build and install
> it on the recent versions of JDK. Seems like there are few things
> in the installation section, that might be improved.
>
> Could anyone please review the patch below?
>
>
>
> diff --git a/src/utils/hsdis/README b/src/utils/hsdis/README
> --- a/src/utils/hsdis/README
> +++ b/src/utils/hsdis/README
> @@ -114,18 +114,16 @@
>
> * Installing
>
> -Products are named like build/$OS-$LIBARCH/hsdis-$LIBARCH.so. You can
> -install them on your LD_LIBRARY_PATH, or inside of your JRE/JDK. The
> -search path in the JVM is:
> -
> -1. <home>/jre/lib/<arch>/<vm>/libhsdis-<arch>.so
> -2. <home>/jre/lib/<arch>/<vm>/hsdis-<arch>.so
> -3. <home>/jre/lib/<arch>/hsdis-<arch>.so
> +Products are named like build/$OS-$LIBARCH/hsdis-$LIBARCH.so. You can
> +install them next to your libjvm.so inside JRE/JDK or alternatively
> +put it anywhere on your LD_LIBRARY_PATH. JVM looks up several paths
> +derived from libjvm.so in the following order:
> +
> +1. <home>/lib/server/libhsdis-<arch>.so
> +2. <home>/lib/server/hsdis-<arch>.so
> +3. <home>/lib/hsdis-<arch>.so
> 4. hsdis-<arch>.so (using LD_LIBRARY_PATH)
>
> -Note that there's a bug in hotspot versions prior to hs22 that causes
> -steps 2 and 3 to fail when used with JDK7.
> -
> Now test:
>
> export LD_LIBRARY_PATH .../hsdis/build/$OS-$LIBARCH:$LD_LIBRARY_PATH
>
>
>
> Thanks,
> Sergei
>