Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8216010

Change callers of build_u2_from() to call Bytes::get_Java_u2() instead

    XMLWordPrintable

Details

    • b03

    Description

      Callers of globalDefinitions.hpp's build_u2_from() should instead call Bytes::get_Java_u2(). And, build_u2_from() should be removed.

      The methods in class Bytes are optimized machine-specifically and may be much faster than globalDefinitions.hpp's build_u2_from() method.

      The current callers of build_u2_from() are:

      open/src/hotspot/share/jvmci/compilerRuntime.cpp: int len = build_u2_from((address)name);
      open/src/hotspot/share/jvmci/compilerRuntime.cpp: int len = build_u2_from((address)name);
      open/src/hotspot/share/jvmci/compilerRuntime.cpp: int method_name_len = build_u2_from((address)data);
      open/src/hotspot/share/jvmci/compilerRuntime.cpp: int signature_name_len = build_u2_from((address)data);
      open/src/hotspot/share/jvmci/compilerRuntime.cpp: int len = build_u2_from((address)name);
      open/src/hotspot/share/aot/aotCompiledMethod.cpp: int klass_len = build_u2_from((address)meta_name);
      open/src/hotspot/share/aot/aotCompiledMethod.cpp: int method_name_len = build_u2_from((address)klass_name + klass_len);
      open/src/hotspot/share/aot/aotCompiledMethod.cpp: int klass_len = build_u2_from((address)meta_name);
      open/src/hotspot/share/aot/aotCompiledMethod.cpp: int method_name_len = build_u2_from((address)klass_name + klass_len);
      open/src/hotspot/share/aot/aotCompiledMethod.cpp: int signature_len = build_u2_from((address)klass_name + klass_len + 2 + method_name_len);
      open/src/hotspot/share/aot/aotCodeHeap.cpp: int len = build_u2_from((address)stub_name);
      open/src/hotspot/share/aot/aotCodeHeap.cpp: int method_name_len = build_u2_from((address)method_name);
      open/src/hotspot/share/aot/aotCodeHeap.cpp: int signature_name_len = build_u2_from((address)signature_name);
      open/src/hotspot/share/aot/aotCodeHeap.cpp: int klass_len = build_u2_from((address)aot_name);

      Attachments

        Issue Links

          Activity

            People

              hseigel Harold Seigel (Inactive)
              hseigel Harold Seigel (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: