Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8216352

SA: ClhsdbLauncher should throw errors on Unrecognized commands

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 14
    • 12, 13
    • hotspot
    • b18
    • generic

      The ClhsdbLauncher test launcher should catch unrecognized commands issued to clhsdb. Snippet from a .jtr file below when 'printmado' instead of 'printmdo' was issued to clhsdb in TestPrintMdo.java

      ==================================================
      ----------System.out:(7/221)----------
      Starting TestPrintMdo test
      Started LingeredApp with pid 28190
      Starting clhsdb against 28190
      Warning! JS Engine can't start, some commands will not be available.
      hsdb> Unrecognized command. Try help...
      hsdb>
      Test PASSED
      ====================================================
      The test passes without actually testing the command.
      Mail snippet from JC Beyler on this:
      =======================================================
      I saw this typo:
      http://cr.openjdk.java.net/~jgeorge/8215568/webrev.00/test/hotspot/jtreg/serviceability/sa/TestPrintMdo.java.udiff.html

      + List<String> cmds = List.of("printmado -a");

      Should it not be printmdo and not printmado? does printmado exist? If it doesn't how does the test pass (my guess is that we do not catch a "unexpected command" and that the hashmaps are not finding the keys so they are not checking the expected/unexpected results; if so perhaps a follow-up should fix that an unknown command fails a test trying to do that / and perhaps if the key is not found, the test fails as well?)
      =====================================================




            fmatte Fairoz Matte
            jgeorge Jini George (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: