P4
We presently have
int os::open(const char* pathname, int flags, int mode);
where the 3rd argument is only meaningful when flags contains certain values, and is otherwise effectively ignored. It would be better to have two overloads
int os::open(const char* pathname, int flags, int mode);
int os::open(const char* pathname, int flags);
where the 2-arg form asserts flags doesn't contain a value that requires mode.
(This suggestion came out of the review forJDK-8218811.)
int os::open(const char* pathname, int flags, int mode);
where the 3rd argument is only meaningful when flags contains certain values, and is otherwise effectively ignored. It would be better to have two overloads
int os::open(const char* pathname, int flags, int mode);
int os::open(const char* pathname, int flags);
where the 2-arg form asserts flags doesn't contain a value that requires mode.
(This suggestion came out of the review for