Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8223188

Removed unnecessary #ifdef __cplusplus from .cpp sources

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P3
    • 17
    • 14, 15, 16, 17
    • tools
    • b09

    Description

      Code review feedback:

      The following files:
      src/jdk.jpackage/windows/native/libjpackage/WindowsRegistry.cpp,
      src/jdk.jpackage/windows/native/libjpackage/jpackage.cpp, and
      src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp
      are completely wrapped with:

      #ifdef __cplusplus
      extern "C" {
      #endif
      ...
      #ifdef __cplusplus
      }
      #endif

      Would it be better to remove these wrappers and either write the source in C++ or move it to ".c" files ?

      Attachments

        Issue Links

          Activity

            People

              asemenyuk Alexey Semenyuk
              herrick Andy Herrick (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: