Code review feedback:
The following files:
src/jdk.jpackage/windows/native/libjpackage/WindowsRegistry.cpp,
src/jdk.jpackage/windows/native/libjpackage/jpackage.cpp, and
src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp
are completely wrapped with:
#ifdef __cplusplus
extern "C" {
#endif
...
#ifdef __cplusplus
}
#endif
Would it be better to remove these wrappers and either write the source in C++ or move it to ".c" files ?
The following files:
src/jdk.jpackage/windows/native/libjpackage/WindowsRegistry.cpp,
src/jdk.jpackage/windows/native/libjpackage/jpackage.cpp, and
src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp
are completely wrapped with:
#ifdef __cplusplus
extern "C" {
#endif
...
#ifdef __cplusplus
}
#endif
Would it be better to remove these wrappers and either write the source in C++ or move it to ".c" files ?
- relates to
-
JDK-8254702 jpackage app launcher crashes on CentOS
- Resolved