Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8226598

Remove distinction between dependencies_failed and dependencies_invalid

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Duplicate
    • Icon: P4 P4
    • tbd
    • 13
    • hotspot

      The distinction in both validate_compile_task_dependencies functions between "dependencies failed" and "dependencies invalid" is even more fuzzy after the change for JDK-8222446.

      1324 // Dependencies must be checked when the system dictionary changes
      1325 // or if we don't know whether it has changed (i.e., compile_state == NULL).

      1326 CompileTask* task = compile_state == NULL ? NULL : compile_state->task();
      1327 Dependencies::DepType result = dependencies->validate_dependencies(task, failure_detail);
      1328 if (result == Dependencies::end_marker) {
      1329 return JVMCI::ok;
      1330 }
      1331
      1332 if (!Dependencies::is_klass_type(result) || compile_state == NULL) {
      1333 return JVMCI::dependencies_failed;
      1334 }
      1335 // The dependencies were invalid at the time of installation
      1336 // without any intervening modification of the system
      1337 // dictionary. That means they were invalidly constructed.
      1338 return JVMCI::dependencies_invalid;
      1339 }

            Unassigned Unassigned
            coleenp Coleen Phillimore
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: