-
Bug
-
Resolution: Fixed
-
P3
-
internal
After code clean up done in JDK-8223586 logic of some code was altered unexpectedly.
E.g.: rename of parameter from "p" to "params" in WindowsAppImageBuilder.createLauncherForEntryPoint():
---
private void createLauncherForEntryPoint(
Map<String, ? super Object> params) throws IOException {
File launcherIcon = ICON_ICO.fetchFrom(params);
File icon = launcherIcon != null ?
launcherIcon : ICON_ICO.fetchFrom(params);
...
}
---
Used to be before renaming:
---
private void createLauncherForEntryPoint(
Map<String, ? super Object> p) throws IOException {
File launcherIcon = ICON_ICO.fetchFrom(p);
File icon = launcherIcon != null ?
launcherIcon : ICON_ICO.fetchFrom(params);
...
}
---
"params" parameter shadows WindowsAppImageBuilder.params member field.
I've discovered this issue accidentally. Probably there are more like this.
E.g.: rename of parameter from "p" to "params" in WindowsAppImageBuilder.createLauncherForEntryPoint():
---
private void createLauncherForEntryPoint(
Map<String, ? super Object> params) throws IOException {
File launcherIcon = ICON_ICO.fetchFrom(params);
File icon = launcherIcon != null ?
launcherIcon : ICON_ICO.fetchFrom(params);
...
}
---
Used to be before renaming:
---
private void createLauncherForEntryPoint(
Map<String, ? super Object> p) throws IOException {
File launcherIcon = ICON_ICO.fetchFrom(p);
File icon = launcherIcon != null ?
launcherIcon : ICON_ICO.fetchFrom(params);
...
}
---
"params" parameter shadows WindowsAppImageBuilder.params member field.
I've discovered this issue accidentally. Probably there are more like this.
- relates to
-
JDK-8223586 remove jpackage dead code and other cleanup
- Resolved