Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8231862

Decouple DesktopIntegration and LinuxPackageBundler classes

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P3 P3
    • internal
    • internal
    • tools
    • generic
    • generic

      DesktopIntegration class is inner in LinuxPackageBundler.
      Just because it depends on LinuxPackageBundler.fetchResource(). It would be good to have these classes separated.

      fetchResource() is declared in AbstractBundler class. Similar functionality is provided by AbstractAppImageBuilder.locateResource().

      AbstractAppImageBuilder.preprocessTextResource() is a copy/paste of AbstractBundler.preprocessTextResource() or vice versa that both provide similar functionality to fetchResource() plus text substitution.

      Move preprocessTextResource() and fetchResource() to a separate class that can be used by bundler classes and by DesktopIntegration class. This would eliminate code duplication between AbstractBundler and AbstractAppImageBuilder classes and allow to decouple DesktopIntegration and LinuxPackageBundler classes.

            asemenyuk Alexey Semenyuk
            asemenyuk Alexey Semenyuk
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: