Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8231986

Consolidate parts of the Linux and MacOSX versions of ps_core.c

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 14
    • None
    • hotspot
    • None
    • b19
    • linux, os_x

      These two files have lots of duplication:
      http://hg.openjdk.java.net/jdk/jdk/file/5b5de2618756/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c
      http://hg.openjdk.java.net/jdk/jdk/file/5b5de2618756/src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c

      Specifically, the code that deals with CDS is almost identical in these two files. The upcoming changes in JDK-8231610 (Relocate the CDS archive if it cannot be mapped to the requested address) would require ps_core.c to be modified, and I don't want to make the same changes twice.

      I this RFE, I plan to merge the parts in ps_core.c that's related to CDS. I'll leave the rest in place for now.

            iklam Ioi Lam
            iklam Ioi Lam
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: