Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8232646

Follow up for JDK-8223325

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4
    • internal
    • internal
    • tools

    Description

      1. http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java.frames.html
      Line 180: man -> main

      2. http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java.frames.html
      createXml() should we force it to UTF-8? Like we did in MacPkgBundler.

      3. http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixTool.java.html
      We cannot assume "C:\Program Files". This folder can be on different drive, so it is better to use Windows API to get path to "Program Files". Also, user might install Wix into different folder. I think it is better to file a bug and improve it eventually.

      Attachments

        Issue Links

          Activity

            People

              asemenyuk Alexey Semenyuk
              asemenyuk Alexey Semenyuk
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: