Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8233021

Shenandoah: SBSC2::is_shenandoah_lrb_call should match all LRB shapes

XMLWordPrintable

    • gc
    • b21

      In current code, we match only one LRB shape:

       bool ShenandoahBarrierSetC2::is_shenandoah_lrb_call(Node* call) {
         return call->is_CallLeaf() &&
                 call->as_CallLeaf()->entry_point() == CAST_FROM_FN_PTR(address, ShenandoahRuntime::load_reference_barrier);
       }

      ...which is not the only shape that is emitted by C2 code.

      Current bug is somewhat benign, because SBSC2::is_shenandoah_lrb_call is used in C2 verification code only, but it could be catastrophic in future.

            shade Aleksey Shipilev
            shade Aleksey Shipilev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: