Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8233027

OopMapSet::all_do does oms.next() twice during iteration

    XMLWordPrintable

Details

    • b21
    • Not verified

    Backports

      Description

        It seems to be introduced by JDK-8232083. New code does oms.next() twice:

            for (OopMapStream oms(map); !oms.is_done(); oms.next()) { // <--- here
              OopMapValue omv = oms.current();
              if (omv.type() != OopMapValue::derived_oop_value) {
                continue;
              }
              ...
              if (base_loc != NULL && *base_loc != NULL && !CompressedOops::is_base(*base_loc)) {
                derived_oop_fn(base_loc, derived_loc);
              }
              oms.next(); // <--- then here
            }

        We are seeing some weird, random, intermittent test failures with Shenandoah in jdk/jdk recently, this might explain it.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8246235 OopMapSet::all_do does oms.next() twice during iteration

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8260423 OopMapSet::all_do does oms.next() twice during iteration

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8261055 OopMapSet::all_do does oms.next() twice during iteration

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8244064 OopMapSet::all_do does oms.next() twice during iteration

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8233024 [Graal] Graal crashed with "assert(is_interpreted_frame()) failed: interpreted frame expected"

            • P3 - Major loss of function.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8233030 assert(inv * n[0] == -1UL) failed: broken inverse in Montgomery multiply

            • P3 - Major loss of function.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8232083 Minimal VM is broken after JDK-8231586

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk13u-dev/0bb10174

            Review Review openjdk/jdk13u-dev/89

            Activity

              People

                never Tom Rodriguez
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: