Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8233339

Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet

XMLWordPrintable

    • gc
    • b23

      JDK-8232008 and JDK-8232009 tried to match interpreter, c1 and c2 load barrier logic, but still not ideal. Because, the decisions, such as, if LRB is needed, or what kind of barrier, are still scattered and duplicated in each barrier, which is hard to maintain and could easily cause mismatch again.

      I would like to add following three methods in SBS to centralize the decision making:

        static bool need_load_reference_barrier(DecoratorSet decorators, BasicType type);
        static bool use_native_load_reference_barrier(DecoratorSet decorators, BasicType type);
        static bool need_keep_alive_barrier(DecoratorSet decorators, BasicType type);

            zgu Zhengyu Gu
            zgu Zhengyu Gu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: