Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8234930

Use MAP_JIT when allocating pages for code cache on macOS

    XMLWordPrintable

Details

    • b02
    • os_x

    Backports

      Description

        According to Apple documentation (e.g. https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_cs_allow-jit ) the MAP_JIT flag should be used when mmap:ing memory for JIT compilers. We should investigate if that flag can and should be used for the code cache.

        On macOS MAP_JIT cannot be used in conjunction with MAP_FIXED when mapping
        a page for codecache. Therefore our traditional technique of doing commit
        and uncommit - replacing a mapping with another one at the same address
        range but swapped MAP_NORESERVE - does not work.
        The "exec" flag basically means "its code cache" and it should be used
        consistently for the same mapping (reserve-commit-uncommit etc)
        This affects pd_reserve_memory, pd_commit_memory, pd_uncommit_memory functions

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8278594 Use MAP_JIT when allocating pages for code cache on macOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281011 Use MAP_JIT when allocating pages for code cache on macOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8287351 Use MAP_JIT when allocating pages for code cache on macOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8266564 Does pd_map_memory() need MAP_JIT?

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8258438 build error in test/hotspot/gtest/runtime/test_os.cpp

            • P1 - Blocks development and/or testing work, production could not run.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8262952 [macos_aarch64] os::commit_memory failure

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8253795 Implementation of JEP 391: macOS/AArch64 Port

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Enhancement - null JDK-8255254 Split os::reserve_memory and os::map_memory_to_file interfaces

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/b77a1657

            Commit Commit openjdk/jdk/2273f955

            Review Review openjdk/jdk11u-dev/580

            Review Review openjdk/jdk11u-dev/710

            Review Review openjdk/jdk/294

            Activity

              People

                akozlov Anton Kozlov
                mikael Mikael Vidstedt
                Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: