Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8235225

Replace CHECK_0 with CHECK_NULL for non-integer returning methods

    XMLWordPrintable

Details

    • b13

    Description

      From the review of "JEP 359: Records"

      "src/hotspot/share/classfile/javaClasses.cpp

      You are using CHECK_0 in RecordComponent::create but that method returns oop. That seems wrong to me, but I see many other oop returning methods also use CHECK_0 so I'll take that up separately. (It's only a cosmetic issue.) "

      John Rose responds:
      CHECK_NULL is clearly preferable. At some point IIRC it was more
      than just cosmetics, because we were getting warning noise about
      `return 0` converting to NULL, from some C++ compiler or other.
      AFAIK such warnings can still happen
      ---
      .
      We should locate and change all such occurrences.

      Attachments

        Activity

          People

            hseigel Harold Seigel (Inactive)
            dholmes David Holmes
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: