-
Type:
Enhancement
-
Resolution: Fixed
-
Priority:
P4
-
Affects Version/s: 14
-
Component/s: hotspot
-
b13
From the review of "JEP 359: Records"
"src/hotspot/share/classfile/javaClasses.cpp
You are using CHECK_0 in RecordComponent::create but that method returns oop. That seems wrong to me, but I see many other oop returning methods also use CHECK_0 so I'll take that up separately. (It's only a cosmetic issue.) "
John Rose responds:
CHECK_NULL is clearly preferable. At some point IIRC it was more
than just cosmetics, because we were getting warning noise about
`return 0` converting to NULL, from some C++ compiler or other.
AFAIK such warnings can still happen
---
.
We should locate and change all such occurrences.
"src/hotspot/share/classfile/javaClasses.cpp
You are using CHECK_0 in RecordComponent::create but that method returns oop. That seems wrong to me, but I see many other oop returning methods also use CHECK_0 so I'll take that up separately. (It's only a cosmetic issue.) "
John Rose responds:
CHECK_NULL is clearly preferable. At some point IIRC it was more
than just cosmetics, because we were getting warning noise about
`return 0` converting to NULL, from some C++ compiler or other.
AFAIK such warnings can still happen
---
.
We should locate and change all such occurrences.