-
Bug
-
Resolution: Fixed
-
P3
-
14, 15
-
Tools summary:
- Environment: cygwin version 2.11.1(0.329/5/3) (root at /cygdrive/c/cygwin64)
- Boot JDK: openjdk version "13-internal" 2019-09-17 OpenJDK Runtime Environment (build 13-internal+0-adhoc..build) OpenJDK 64-Bit Server VM (build 13-internal+0-adhoc..build, mixed mode, sharing) (at /cygdrive/c/cygwin64/home/windows/jdks/jdk13)
- Toolchain: microsoft (Microsoft Visual Studio 2013)
- C Compiler: Version 18.00.31101 (at /cygdrive/c/progra~2/micros~1.0/vc/bin/x86_am~1/cl)
- C++ Compiler: Version 18.00.31101 (at /cygdrive/c/progra~2/micros~1.0/vc/bin/x86_am~1/cl)
Tools summary: Environment: cygwin version 2.11.1(0.329/5/3) (root at /cygdrive/c/cygwin64) Boot JDK: openjdk version "13-internal" 2019-09-17 OpenJDK Runtime Environment (build 13-internal+0-adhoc..build) OpenJDK 64-Bit Server VM (build 13-internal+0-adhoc..build, mixed mode, sharing) (at /cygdrive/c/cygwin64/home/windows/jdks/jdk13) Toolchain: microsoft (Microsoft Visual Studio 2013) C Compiler: Version 18.00.31101 (at /cygdrive/c/progra~2/micros~1.0/vc/bin/x86_am~1/cl) C++ Compiler: Version 18.00.31101 (at /cygdrive/c/progra~2/micros~1.0/vc/bin/x86_am~1/cl)
-
b06
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8237426 | 14.0.1 | Unassigned | P3 | Resolved | Fixed | b01 |
| JDK-8237040 | 14 | Alex Kasko | P3 | Resolved | Fixed | b32 |
* For target support_native_jdk.incubator.jpackage_libjpackage_WindowsRegistry.obj:
WindowsRegistry.cpp
c:\progra~2\micros~1.0\vc\include\tchar.h(24) : fatal error C1189: #error : Need to include strsafe.h after tchar.h
... (rest of output omitted)
Simple fix is to change the order of includes as error message wants it:
diff -r b8b54ebb450a src/jdk.incubator.jpackage/windows/native/libjpackage/WindowsRegistry.cpp
--- a/src/jdk.incubator.jpackage/windows/native/libjpackage/WindowsRegistry.cpp Tue Dec 17 10:00:55 2019 +0900
+++ b/src/jdk.incubator.jpackage/windows/native/libjpackage/WindowsRegistry.cpp Tue Dec 17 21:42:11 2019 +0300
@@ -24,8 +24,8 @@
*/
#include <Windows.h>
+#include <tchar.h>
#include <strsafe.h>
-#include <tchar.h>
#include <jni.h>
#include "Utils.h"
WindowsRegistry.cpp
c:\progra~2\micros~1.0\vc\include\tchar.h(24) : fatal error C1189: #error : Need to include strsafe.h after tchar.h
... (rest of output omitted)
Simple fix is to change the order of includes as error message wants it:
diff -r b8b54ebb450a src/jdk.incubator.jpackage/windows/native/libjpackage/WindowsRegistry.cpp
--- a/src/jdk.incubator.jpackage/windows/native/libjpackage/WindowsRegistry.cpp Tue Dec 17 10:00:55 2019 +0900
+++ b/src/jdk.incubator.jpackage/windows/native/libjpackage/WindowsRegistry.cpp Tue Dec 17 21:42:11 2019 +0300
@@ -24,8 +24,8 @@
*/
#include <Windows.h>
+#include <tchar.h>
#include <strsafe.h>
-#include <tchar.h>
#include <jni.h>
#include "Utils.h"
- backported by
-
JDK-8237040 Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h
-
- Resolved
-
-
-
- Resolved
-