Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8236228

clean up BarrierSet headers in c1_LIRAssembler

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 15
    • 14, 15
    • hotspot
    • b06

    Description

      BarrierSet has nothing to do with c1's LIRAssembler. They all go to macroAssembler.

      eg.change as follows can still build on x86_64.

      diff --git a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp
      --- a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp
      +++ b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp
      @@ -32,8 +32,6 @@
       #include "c1/c1_ValueStack.hpp"
       #include "ci/ciArrayKlass.hpp"
       #include "ci/ciInstance.hpp"
      -#include "gc/shared/barrierSet.hpp"
      -#include "gc/shared/cardTableBarrierSet.hpp"
       #include "gc/shared/collectedHeap.hpp"
       #include "nativeInst_x86.hpp"
       #include "oops/objArrayKlass.hpp"

      Attachments

        Activity

          People

            xliu Xin Liu
            xliu Xin Liu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: