Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8236900

atomic_windows_x86.hpp disables warning 4035 more widely than needed

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Duplicate
    • P4
    • tbd
    • 15
    • hotspot
    • None
    • x86
    • windows

    Description

      atomic_windows_x86.hpp disables warning 4035 (missing return statement) over most (though not all) of the file. That warning only needs to be disabled over the !defined(AMD64) part of the file though, to deal with the code that uses __asm statements. The scope of the warning suppression should be narrowed accordingly.

      The suppression should probably also be scoped by using the warning push/pop mechanism, rather than resetting to the default, which might not have been the original state.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: