Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8238249

GetPrimitiveArrayCritical passed with hardcoded FALSE value

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • jfx11, 8
    • jfx15
    • javafx

    Backports

      Description

        The following call to GetPrimitiveArrayCritical in jpegloader.c is misleading:

                   jboolean iscopy = FALSE;
                    jbyte *body = (*env)->GetPrimitiveArrayCritical(env, barray, &iscopy);

        It looks like we want to pass "FALSE" to the isCopy parameter of GetPrimitiveArrayCritical, while this field is actually set by the VM when it informs the caller whether a copy is made or not. The jscopy parameter is not used outside this scope.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8240864 GetPrimitiveArrayCritical passed with hardcoded FALSE value

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8247978 GetPrimitiveArrayCritical passed with hardcoded FALSE value

            • P3 - Major loss of function.
            • Closed
            blocks

            Bug - A problem which impairs or prevents the functions of the product. JDK-8212034 Potential memory leaks in jpegLoader.c in error case

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jfx/ca37c1fb

            Review Review openjdk/jfx/101

            Activity

              People

                jvos Johan Vos
                jvos Johan Vos
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: