GetPrimitiveArrayCritical passed with hardcoded FALSE value

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: P3
    • jfx15
    • Affects Version/s: jfx11, 8
    • Component/s: javafx

        The following call to GetPrimitiveArrayCritical in jpegloader.c is misleading:

                   jboolean iscopy = FALSE;
                    jbyte *body = (*env)->GetPrimitiveArrayCritical(env, barray, &iscopy);

        It looks like we want to pass "FALSE" to the isCopy parameter of GetPrimitiveArrayCritical, while this field is actually set by the VM when it informs the caller whether a copy is made or not. The jscopy parameter is not used outside this scope.

              Assignee:
              Johan Vos
              Reporter:
              Johan Vos
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: