Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8238371

ObjectSynchronizer::om_alloc() does not have to be public

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Duplicate
    • Icon: P4 P4
    • None
    • 15
    • hotspot
    • generic
    • generic

      Coleen raised a possible RFE in her review of:

      JDK-8235795 replace monitor list mux{Acquire,Release}(&gListLock) with spin locks

      > The function om_malloc() and many of these are 'public' in ObjectSynchronizer when they're only called within. As a new RFE, can you make them private (or even static private if possible)?
       
      s/om_malloc()/om_alloc()/

      Definitely makes sense to make more stuff private and, if possible,
      static private. This fix (8235795) includes a bit of that, but
      there's more room for improvement.

            dcubed Daniel Daugherty
            dcubed Daniel Daugherty
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: