-
Bug
-
Resolution: Fixed
-
P3
-
jfx11, jfx12, 8
-
x86_64
-
generic
A DESCRIPTION OF THE PROBLEM :
com.sun.javafx.css.StyleManager.calculateCheckSum uses a raw InputStream as the input to a DigestInputStream. The InputStream should be wrapped in a BufferedInputStream to improve performance. Thus:
try (final InputStream stream = url.openStream();
final BufferedInputStream bstream = new BufferedInputStream(stream);
final DigestInputStream dis = new DigestInputStream(bstream, MessageDigest.getInstance("MD5")); ) {
dis.getMessageDigest().reset();
while (dis.read() != -1) { /* empty loop body is intentional */ }
return dis.getMessageDigest().digest();
}
Alternatively (preferably) move the IO to java.nio.file.
com.sun.javafx.css.StyleManager.calculateCheckSum uses a raw InputStream as the input to a DigestInputStream. The InputStream should be wrapped in a BufferedInputStream to improve performance. Thus:
try (final InputStream stream = url.openStream();
final BufferedInputStream bstream = new BufferedInputStream(stream);
final DigestInputStream dis = new DigestInputStream(bstream, MessageDigest.getInstance("MD5")); ) {
dis.getMessageDigest().reset();
while (dis.read() != -1) { /* empty loop body is intentional */ }
return dis.getMessageDigest().digest();
}
Alternatively (preferably) move the IO to java.nio.file.
- duplicates
-
JDK-8263875 CSS StyleManager has poor performance due to unbuffered input stream
- Closed
- relates to
-
JDK-8267892 Add .gitattributes to repo
- Resolved