Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8239351

Give more meaningful InternalError messages in Deflater.c

    XMLWordPrintable

Details

    • b12
    • generic
    • generic

    Backports

      Description

        When running the jtreg test java/util/zip/DeInflate.java, we currently have errors on SLES 15.1 s390x when using the system zlib (1.2.11), while the bundled zlib seems to be okay.
        What's worse, the error messages are not very meaningful.

        We just get:
        java.lang.InternalError
        at java.base/java.util.zip.Deflater.deflateBytesBytes(Native Method)
        at java.base/java.util.zip.Deflater.deflate(Deflater.java:595)
        at java.base/java.util.zip.Deflater.deflate(Deflater.java:474)
        ...
        without any meaningful error text.

        I would suggest to improve a bit the error messages in Deflater.c. This would lead to:

        java.lang.InternalError: unknown error in checkDeflateStatus, setParams case
        at java.base/java.util.zip.Deflater.deflateBytesBytes(Native Method)
        at java.base/java.util.zip.Deflater.deflate(Deflater.java:586)
        at java.base/java.util.zip.Deflater.deflate(Deflater.java:465)

        The following messages were added:

        unknown error in checkSetDictionaryResult
        unknown error in checkDeflateStatus, setParams case
        unknown error in checkDeflateStatus
        deflateReset failed
        deflateEnd failed

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8240736 Give more meaningful InternalError messages in Deflater.c

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8246548 Give more meaningful InternalError messages in Deflater.c

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8249959 Give more meaningful InternalError messages in Deflater.c

            • P3 - Major loss of function.
            • Resolved

            Activity

              People

                mbaesken Matthias Baesken
                mbaesken Matthias Baesken
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: