Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8239400

[8u] clean up delete-non-virtual-dtor warnings in HotSpot

    XMLWordPrintable

Details

    • b01
    • Not verified

    Backports

      Description

        There are a number of delete-non-virtual-dtor warnings which cause compilation failure on recent versions of Xcode. We will fix this warning as part of our toolchain upgrade effort.

        This is not simply a warnings cleanup. HotSpot crashes when built with Xcode 10.1 without the fix to PerfData destructor.

        This is a partial backport of Paul Hohensee's massive cleanup [0] of Xcode warnings. A complete backport of that chnageset is well beyond the scope of our toolchain upgrade work. But we do want to clean up as many warnings as we can with minimal risk.

        Unlike Paul's fix, for 8u we only added / modified destructor declarations in the base classes and did *not* add explicit destructors to any of the derived classes. We also left the delete-non-virtual-dtor warnings disabled as it is believed that this warning frequently triggers false positives and has subsequently been re-enabled in mainline.

        [0] http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/c044f8d03932

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8244878 [8u] clean up delete-non-virtual-dtor warnings in HotSpot

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8246875 [8u] clean up delete-non-virtual-dtor warnings in HotSpot

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8248938 [8u] clean up delete-non-virtual-dtor warnings in HotSpot

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8251616 [8u] clean up delete-non-virtual-dtor warnings in HotSpot

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8267848 [8u] clean up delete-non-virtual-dtor warnings in HotSpot

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Activity

              People

                dbuck David Buck
                dbuck David Buck
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: