Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8240133

G1DirtyCardQueue destructor has useless flush

    XMLWordPrintable

Details

    • gc
    • b14
    • Fix failed

    Description

      ~G1DirtyCardQueue calls flush(), but that's too late. The final flush must occur in on_thread_detach(), with no further queued log entries after that, else operations like concatenate_logs won't be able to find and process those late logs. on_thread_detach() already contains the necessary flush(), so the one in the destructor is just a waste of time, and possibly hides bugs. Better to just remove it.

      Attachments

        Issue Links

          Activity

            People

              kbarrett Kim Barrett
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: