~G1DirtyCardQueue calls flush(), but that's too late. The final flush must occur in on_thread_detach(), with no further queued log entries after that, else operations like concatenate_logs won't be able to find and process those late logs. on_thread_detach() already contains the necessary flush(), so the one in the destructor is just a waste of time, and possibly hides bugs. Better to just remove it.