-
Type:
Enhancement
-
Resolution: Fixed
-
Priority:
P4
-
Affects Version/s: 8-shenandoah, 11.0.9, 14, 15
-
Component/s: hotspot
-
b16
Static analyzers say heap argument is unused here:
bool ShenandoahNMethod::has_cset_oops(ShenandoahHeap *heap) {
ShenandoahHasCSetOopClosure cl;
oops_do(&cl);
return cl.has_cset_oops();
}
ShenandoahHasCSetOopClosure gets the heap in its own constructor. Either we should drop the parameter from SHNM::has_cset_oops, or we should pass it to ShenandoahHasCSetOopClosure, depending on which produces the better code.
bool ShenandoahNMethod::has_cset_oops(ShenandoahHeap *heap) {
ShenandoahHasCSetOopClosure cl;
oops_do(&cl);
return cl.has_cset_oops();
}
ShenandoahHasCSetOopClosure gets the heap in its own constructor. Either we should drop the parameter from SHNM::has_cset_oops, or we should pass it to ShenandoahHasCSetOopClosure, depending on which produces the better code.