-
Bug
-
Resolution: Fixed
-
P3
-
8, 11, 14, 15
-
b20
-
generic
-
generic
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8245391 | 14u-cpu | Severin Gehwolf | P3 | Resolved | Fixed | master |
JDK-8245229 | 14.0.2 | Severin Gehwolf | P3 | Resolved | Fixed | b07 |
JDK-8245277 | 13.0.4 | Severin Gehwolf | P3 | Resolved | Fixed | b02 |
JDK-8244079 | 11.0.8 | Severin Gehwolf | P3 | Resolved | Fixed | b02 |
JDK-8245252 | openjdk8u262 | Severin Gehwolf | P3 | Resolved | Fixed | b03 |
When attempting a build like so:
$ configure [....] --with-vendor-name="THL A29 Limited, a Tencent company" [...]
$ make images
It fails with:
gmake[2]: *** [make/Main.gmk:221: java.base-launchers] Error 2
gmake[2]: *** Waiting for unfinished jobs....
gmake[3]: Entering directory '/disk/openjdk/upstream-sources/openjdk-head/make'
Looking closer one notices this for SetupJdkExecutable BUILD_LAUNCHER_java:
SetupJdkExecutable BUILD_LAUNCHER_java
[2] NAME := java
[3] EXTRA_FILES := /disk/openjdk/upstream-sources/openjdk-head/src/java.base/share/native/launcher/main.c
[4] OPTIMIZATION := HIGH
[5] CFLAGS := -I/disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-server-release/support/modules_include/java.base -I/disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-server-release/support/modules_include/java.base/linux -I/disk/openjdk/upstream-sources/openjdk-head/src/java.base/share/native/libjava -I/disk/openjdk/upstream-sources/openjdk-head/src/java.base/unix/native/libjava -I/disk/openjdk/upstream-sources/openjdk-head/src/hotspot/share/include -I/disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os/posix/include -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -DLINUX -DNDEBUG -fmacro-prefix-map=/disk/openjdk/upstream-sources/openjdk-head/= -std=c99 -fno-strict-aliasing -Wall -Wextra ...
[6] a Tencent company"' -DVENDOR_URL='"https://openjdk.java.net/"' -DVENDOR_URL_BUG='"https://bugreport.java.com/bugreport/"' -DVENDOR_URL_VM_BUG='"https://bugreport.java.com/bugreport/crash.jsp"' -DLAUNCHER_NAME='"openjdk"' -DPROGNAME='"java"' -DEXPAND_CLASSPATH_WILDCARDS -DENABLE_ARG_FILES -DJAVA_ARGS='{ "-J-ms8m", }'
[7] CFLAGS_solaris := -KPIC
Note that parameter '[6]' is bogus:
[6] a Tencent company"' -DVENDOR_URL='"https://openjdk.java.net/"' -DVENDOR_URL_BUG='"https://bugreport.java.com/bugreport/"' -DVENDOR_URL_VM_BUG='"https://bugreport.java.com/bugreport/crash.jsp"' -DLAUNCHER_NAME='"openjdk"' -DPROGNAME='"java"' -DEXPAND_CLASSPATH_WILDCARDS -DENABLE_ARG_FILES -DJAVA_ARGS='{ "-J-ms8m", }'
The comma got expanded and interpreted as a parameter separator!
$ configure [....] --with-vendor-name="THL A29 Limited, a Tencent company" [...]
$ make images
It fails with:
gmake[2]: *** [make/Main.gmk:221: java.base-launchers] Error 2
gmake[2]: *** Waiting for unfinished jobs....
gmake[3]: Entering directory '/disk/openjdk/upstream-sources/openjdk-head/make'
Looking closer one notices this for SetupJdkExecutable BUILD_LAUNCHER_java:
SetupJdkExecutable BUILD_LAUNCHER_java
[2] NAME := java
[3] EXTRA_FILES := /disk/openjdk/upstream-sources/openjdk-head/src/java.base/share/native/launcher/main.c
[4] OPTIMIZATION := HIGH
[5] CFLAGS := -I/disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-server-release/support/modules_include/java.base -I/disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-server-release/support/modules_include/java.base/linux -I/disk/openjdk/upstream-sources/openjdk-head/src/java.base/share/native/libjava -I/disk/openjdk/upstream-sources/openjdk-head/src/java.base/unix/native/libjava -I/disk/openjdk/upstream-sources/openjdk-head/src/hotspot/share/include -I/disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os/posix/include -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -DLINUX -DNDEBUG -fmacro-prefix-map=/disk/openjdk/upstream-sources/openjdk-head/= -std=c99 -fno-strict-aliasing -Wall -Wextra ...
[6] a Tencent company"' -DVENDOR_URL='"https://openjdk.java.net/"' -DVENDOR_URL_BUG='"https://bugreport.java.com/bugreport/"' -DVENDOR_URL_VM_BUG='"https://bugreport.java.com/bugreport/crash.jsp"' -DLAUNCHER_NAME='"openjdk"' -DPROGNAME='"java"' -DEXPAND_CLASSPATH_WILDCARDS -DENABLE_ARG_FILES -DJAVA_ARGS='{ "-J-ms8m", }'
[7] CFLAGS_solaris := -KPIC
Note that parameter '[6]' is bogus:
[6] a Tencent company"' -DVENDOR_URL='"https://openjdk.java.net/"' -DVENDOR_URL_BUG='"https://bugreport.java.com/bugreport/"' -DVENDOR_URL_VM_BUG='"https://bugreport.java.com/bugreport/crash.jsp"' -DLAUNCHER_NAME='"openjdk"' -DPROGNAME='"java"' -DEXPAND_CLASSPATH_WILDCARDS -DENABLE_ARG_FILES -DJAVA_ARGS='{ "-J-ms8m", }'
The comma got expanded and interpreted as a parameter separator!
- backported by
-
JDK-8244079 Build fails when --with-vendor-name contains a comma
-
- Resolved
-
-
JDK-8245229 Build fails when --with-vendor-name contains a comma
-
- Resolved
-
-
JDK-8245252 Build fails when --with-vendor-name contains a comma
-
- Resolved
-
-
JDK-8245277 Build fails when --with-vendor-name contains a comma
-
- Resolved
-
-
JDK-8245391 Build fails when --with-vendor-name contains a comma
-
- Resolved
-