Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8244075

Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene

    XMLWordPrintable

Details

    • generic
    • generic

    Backports

      Description

        This was found while working on JDK-8175358 as a review comment in PR - https://github.com/openjdk/jfx/pull/199.

        It can be easily reproduced by either modifying test JDK-8175358 in to use a ContextMenu or running following JunitTest (to be added in AcceleratorParameterizedTest.java)

        @Test public void testAcceleratorIsNotFiredWhenMenuItemRemovedFromScene() {
                KeyEventFirer kb = new KeyEventFirer(item1, scene);

                kb.doKeyPress(KeyCode.DIGIT1, KeyModifier.ALT);
                assertEquals(1, eventCounter);

                // Remove all children from the scene
                Group root = (Group)scene.getRoot();
                root.getChildren().clear();

                kb.doKeyPress(KeyCode.DIGIT1, KeyModifier.ALT);
                assertEquals(1, eventCounter);
            }

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279787 Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene

            • P3 - Major loss of function.
            • Resolved
            blocks

            Bug - A problem which impairs or prevents the functions of the product. JDK-8274022 Additional Memory Leak in ControlAcceleratorSupport

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved
            is blocked by

            Enhancement - null JDK-8231692 Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8268374 MenuItem's accelerator gets fired even when ContextMenu is set to null

            • P3 - Major loss of function.
            • Open

            Bug - A problem which impairs or prevents the functions of the product. JDK-8283449 TabPane/Tab memory leak

            • P3 - Major loss of function.
            • Open

            Bug - A problem which impairs or prevents the functions of the product. JDK-8175358 Memory leak when moving MenuButton into another Scene

            • P3 - Major loss of function.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8283551 ControlAcceleratorSupport menu items listener causes memory leak

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jfx/0ffa8e28

            Review Review openjdk/jfx/515

            Activity

              People

                arapte Ambarish Rapte
                aghaisas Ajit Ghaisas
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: