Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8244112

Skin implementations: must not violate contract of dispose

    XMLWordPrintable

Details

    Description

      From dispose doc:

      The methods getSkinnable() and getNode() should return null following a call to dispose. Calling dispose twice has no effect.

      The last sentence in particular implies that the calling code need not worry about duplicate calls (either by the caller itself or any other), that is the following test must pass:

          @Test
          public void testSkinDispose() {
              showControl();
              control.getSkin().dispose();
              control.getSkin().dispose();
          }
          
      It fails for some skins with an NPE, f.i. Tree/TableCell, Tree/TableView (there might be others, not yet tested). It's probably one of the reaons for JDK-8243940. Extracted this because the other issue might reveal additional quirks.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. JDK-8217953 NullPointerException when TableCellSkin gets disposed twice

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8243940 NullPointerException in TableCellSkin when automatically resizing cells

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8244419 TextAreaSkin: throws UnsupportedOperation on dispose

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8217953 NullPointerException when TableCellSkin gets disposed twice

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Enhancement - null JDK-8244531 Tests: add support to identify recurring issues with controls et al

          • P3 - Major loss of function.
          • Resolved
          links to

          Web Link Commit openjdk/jfx/bb243224

          Web Link Review openjdk/jfx/209

          Activity

            People

              fastegal Jeanette Winzenburg
              fastegal Jeanette Winzenburg
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: