Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8245831

Unify code parsing version strings on Mac and Windows

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 15
    • 15
    • tools
    • b26
    • generic

      MacAppBundler.validCFBundleVersion() and MacAppImageBuilder.validCFBundleVersion() functions are duplicates.
      MacAppBundler.validCFBundleVersion() and WinMsiBundler.isVersionStringValid() functions duplicate functionality of DottedVersion class that parses dot separated version strings.

      It is better to move functionality of MacAppBundler.validCFBundleVersion() and WinMsiBundler.isVersionStringValid() functions to separate classes with unit test coverage. Implementation of these classes should be based on DottedVersion class.

            asemenyuk Alexey Semenyuk
            asemenyuk Alexey Semenyuk
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: