Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8250635

MethodArityHistogram should use Compile_lock in favour of fancy checks

    XMLWordPrintable

Details

    • 12
    • b18
    • generic
    • generic

    Backports

      Description

        Back in 2018, JDK-8209588, and shortly after, JDK-8209950 was filed. The remedy to the observed SIGSEGV was to call a method which would use heuristics, guided by prior observations, to find out if the storage at hand was safe to be interpreted a nmethod object.

        Meanwhile, further insights led to the conclusion that the Compile_lock should be held (in addition to the CodeCache_lock) while constructing the MethodArityHistogram. Holding that additional lock would make it obsolete to rely on heuristics.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8265269 MethodArityHistogram should use Compile_lock in favour of fancy checks

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8209950 SIGBUS in CodeHeapState::print_names()

            • P3 - Major loss of function.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8209588 SIGSEGV in MethodArityHistogram() with -XX:+CountCompiledCalls

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk/0bc01da7

            Review Review openjdk/jdk/321

            Activity

              People

                lucy Lucy Schmidt
                lucy Lucy Schmidt
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: