Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8234693 Consolidate CDS static and dynamic archive dumping code
  3. JDK-8250989

Consolidate buffer allocation code for CDS static/dynamic dumping

    XMLWordPrintable

Details

    • b09

    Description

      When a static CDS archive is dumped, we unconditionally allocate a 4GB ReservedSpace and use that as the buffer for writing the archive content. We usually don't need such a big ReservedSpace. It also unnecessarily complicates Metaspace::global_initialize().

      http://hg.openjdk.java.net/jdk/jdk/file/4d36e29a5410/src/hotspot/share/memory/metaspaceShared.cpp#l286

      When a dynamic CDS archive is dumped, we allocate a buffer that's just big enough. That way we are less likely to run out of memory:

      http://hg.openjdk.java.net/jdk/jdk/file/4d36e29a5410/src/hotspot/share/memory/dynamicArchive.cpp#l730

      It makes no sense to have two different buffer allocation code. We should always use the second variant since it's more frugal and less intrusive.

      Attachments

        Issue Links

          is blocked by

          Enhancement - null JDK-8256172 Clean up CDS handling of i2i_entry

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Sub-task - The sub-task of the issue JDK-8250990 Consolidate object copying code for CDS static/dynamic archive dumping

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8261552 s390: MacroAssembler::encode_klass_not_null() may produce wrong results for non-zero values of narrow klass base

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8261608 Move common CDS archive building code to archiveBuilder.cpp

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jdk/c5ff4544

          Review Review openjdk/jdk/2296

          Activity

            People

              iklam Ioi Lam
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: