David H. sent the following e-mail:
On 8/16/20 10:42 PM, David Holmes wrote:
<snip>
> I see you pushed this but it isn't really what I was looking for.
> Specifically I wanted the fact that an all-zero header meant
> "inflating" would be clear from the added text. At the moment if I see:
>
> // [ptr | 00] locked ptr points to real header on stack
>
> // [header | 0 | 01] unlocked regular object header
>
> // [ptr | 10] monitor inflated lock (header is wapped out)
>
> // [ptr | 11] marked used to mark an object
>
> then it appears that checking for 00 in lsb is sufficient to identify a
> locked object. But that isn't true because all zeros means inflating.
> I had hoped to see that explicitly added e.g.
>
> // [0 ... 0| 00] inflating inflation in progress
>
> then your new text. At a minimum I would have liked the new text
> to actually state that the INFLATING value is all zeroes.
>
> Sorry that my expectations were not clear enough.
On 8/16/20 10:42 PM, David Holmes wrote:
<snip>
> I see you pushed this but it isn't really what I was looking for.
> Specifically I wanted the fact that an all-zero header meant
> "inflating" would be clear from the added text. At the moment if I see:
>
> // [ptr | 00] locked ptr points to real header on stack
>
> // [header | 0 | 01] unlocked regular object header
>
> // [ptr | 10] monitor inflated lock (header is wapped out)
>
> // [ptr | 11] marked used to mark an object
>
> then it appears that checking for 00 in lsb is sufficient to identify a
> locked object. But that isn't true because all zeros means inflating.
> I had hoped to see that explicitly added e.g.
>
> // [0 ... 0| 00] inflating inflation in progress
>
> then your new text. At a minimum I would have liked the new text
> to actually state that the INFLATING value is all zeroes.
>
> Sorry that my expectations were not clear enough.
- relates to
-
JDK-8251543 add mention of INFLATING() to share/oops/markWord.hpp header comment
-
- Resolved
-