Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8252387

Deprecate for removal css Selector and ShapeConverter constructors

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • jfx15
    • jfx16
    • javafx
    • None

    Description

      During the review of JDK-8251353 we discovered that two of the classes without explicit constructors were not meant to have publicly visible constructors.

      javafx.css.Selector
      javafx.css.converter.ShapeConverter

      We should remove them (by changing the constructors to package-scope or private) over the course of two releases as follows:

      1. Deprecate the constructors for removal in JavaFX 16

      2. Remove the public constructors, replacing them with package-scope (in the case of Selector) or private (in the case of ShapeConverter). Since ShapeConverter is not meant to be subclassed at all, even internally, we can consider making that class final at the same time.

      This will need a CSR.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. JDK-8252783 Remove the css Selector and ShapeConverter constructors

          • P3 - Major loss of function.
          • Resolved

          Task - A task that needs to be done. JDK-8250558 ☂ Many JavaFX classes have implicit no-arg constructors

          • P3 - Major loss of function.
          • Resolved
          csr for

          CSR - null JDK-8252462 Deprecate for removal css Selector and ShapeConverter constructors

          • P3 - Major loss of function.
          • Closed
          relates to

          Enhancement - null JDK-8252782 Enable missing-explicit-ctor lint option by default for JavaFX builds

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8251353 Many javafx scenegraph classes have implicit no-arg constructors

          • P3 - Major loss of function.
          • Resolved
          links to

          Commit Commit openjdk/jfx/a5ecfb68

          Review Review openjdk/jfx/290

          Activity

            People

              bchoudhary Bhawesh Choudhary (Inactive)
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: