Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8252414

Redundant suspend check when determining if a java thread is safe

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 16
    • 16
    • hotspot
    • None
    • b14

    Description

      In JDK-8221207 - "Redo JDK-8218446 - SuspendAtExit hangs" we fixed so a thread is always blocked when suspended.
      And added this nice assert.
      int JavaThread::java_suspend_self() {
        assert(thread_state() == _thread_blocked, "wrong state for java_suspend_self()");

      When checking if a thread is safepoint/handshake safe there no need to look at ext suspend flag anymore, since the thread is blocked.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8221207 Redo JDK-8218446 - SuspendAtExit hangs

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8218446 SuspendAtExit hangs

          • P3 - Major loss of function.
          • Closed

          Enhancement - null JDK-8253241 Update comment on java_suspend_self_with_safepoint_check()

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8252521 possible race in java_suspend_self_with_safepoint_check

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              rehn Robbin Ehn
              rehn Robbin Ehn
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: