-
Enhancement
-
Resolution: Fixed
-
P4
-
11, 16
-
b19
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8283838 | 11.0.16-oracle | Aarti Bijlani | P4 | Resolved | Fixed | b01 |
JDK-8284143 | 11.0.16 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
separating the commit from PR 370 / JDK-8252003: https://github.com/openjdk/jdk/pull/370/commits/5219b11650c00f9af5564758b3292458a48e7f21#r497658983
jvmti_tools.cpp supports ` `, `~` and/or `,` as delimiters[*] in -agentlib options, but nsk/share/jvmti/ArgumentHandler takes these options (via getAgentOptionsString) and then parse in parseOptionString, where StringTokenizer is used w/ default delimiters, ie \t\n\r\f, and as a result, it doesn't split options correctly in tests which use delimiters other than ' '. and in fact, nsk/jvmti/scenarios/contention/TC05/tc05t001 is using ',' and gets wrong options/values.
[*] https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp#L224
jvmti_tools.cpp supports ` `, `~` and/or `,` as delimiters[*] in -agentlib options, but nsk/share/jvmti/ArgumentHandler takes these options (via getAgentOptionsString) and then parse in parseOptionString, where StringTokenizer is used w/ default delimiters, ie \t\n\r\f, and as a result, it doesn't split options correctly in tests which use delimiters other than ' '. and in fact, nsk/jvmti/scenarios/contention/TC05/tc05t001 is using ',' and gets wrong options/values.
[*] https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp#L224
- backported by
-
JDK-8283838 ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
- Resolved
-
JDK-8284143 ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
- Resolved
- links to
-
Commit openjdk/jdk11u-dev/f2b92d04
-
Commit openjdk/jdk/4b16f8ab
-
Review openjdk/jdk11u-dev/961
-
Review openjdk/jdk/438
(1 links to)