-
Bug
-
Resolution: Fixed
-
P3
-
jfx16
The ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing test, which was newly added as part of JDK-8209788, fails on Mac and Linux. It runs fine on Windows.
To reproduce this, run `gradle :controls:test` on Mac or Linux.
Mac:
test.javafx.scene.control.ComboBoxTest > testEditorKeyInputsWhenPopupIsShowing FAILED
java.lang.AssertionError: expected:<4> but was:<0>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at org.junit.Assert.assertEquals(Assert.java:454)
at test.javafx.scene.control.ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing(ComboBoxTest.java:1390)
Linux:
test.javafx.scene.control.ComboBoxTest > testEditorKeyInputsWhenPopupIsShowing FAILED
java.lang.AssertionError: expected:<4> but was:<3>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at org.junit.Assert.assertEquals(Assert.java:454)
at test.javafx.scene.control.ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing(ComboBoxTest.java:1390)
This looks like a test bug, at least in the case of the Mac platform, since Mac uses different key modifiers in some cases. I'm not sure about Linux, but it's likely a test bug, too.
The CTRL-right/left_arrow test fails on both Mac and Linux (this is unsurprising, at least on Mac). Additionally, if those are commented out, the CTRL-home/end and SHIFT-CTRL-home/end tests fail on Mac (this is also unsurprising).
The tests will need to be adjusted, either by skipping them on the failing platforms, or by using a different key modifier on Mac (not sure about Linux).
To reproduce this, run `gradle :controls:test` on Mac or Linux.
Mac:
test.javafx.scene.control.ComboBoxTest > testEditorKeyInputsWhenPopupIsShowing FAILED
java.lang.AssertionError: expected:<4> but was:<0>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at org.junit.Assert.assertEquals(Assert.java:454)
at test.javafx.scene.control.ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing(ComboBoxTest.java:1390)
Linux:
test.javafx.scene.control.ComboBoxTest > testEditorKeyInputsWhenPopupIsShowing FAILED
java.lang.AssertionError: expected:<4> but was:<3>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at org.junit.Assert.assertEquals(Assert.java:454)
at test.javafx.scene.control.ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing(ComboBoxTest.java:1390)
This looks like a test bug, at least in the case of the Mac platform, since Mac uses different key modifiers in some cases. I'm not sure about Linux, but it's likely a test bug, too.
The CTRL-right/left_arrow test fails on both Mac and Linux (this is unsurprising, at least on Mac). Additionally, if those are commented out, the CTRL-home/end and SHIFT-CTRL-home/end tests fail on Mac (this is also unsurprising).
The tests will need to be adjusted, either by skipping them on the failing platforms, or by using a different key modifier on Mac (not sure about Linux).
- relates to
-
JDK-8209788 Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing
- Resolved