Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8254311

Incorrect statements in createWindowsDevkit2017.sh

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 16
    • 16
    • infrastructure
    • None
    • b20
    • windows

      While investigating JDK-8254252 that seems to have been triggered by the Windows AArch64 Support change (JDK-8248238), I found this part which looks incorrect to me:

      -cp $DEVKIT_ROOT/VC/redist/x64/$MSVCP_DLL $DEVKIT_ROOT/VC/bin/x64
      +cp $DEVKIT_ROOT/VC/redist/x64/$MSVCR_DLL $DEVKIT_ROOT/VC/bin/x64
      +cp $DEVKIT_ROOT/VC/redist/arm64/$MSVCP_DLL $DEVKIT_ROOT/VC/bin/arm64
      +cp $DEVKIT_ROOT/VC/redist/arm64/$MSVCP_DLL $DEVKIT_ROOT/VC/bin/arm64
      https://openjdk.github.io/cr/?repo=jdk&pr=212&range=11#udiff-6

      Why is MSVCP_DLL changed to MSVCR_DLL for x86? And why are the two arm64 specific lines duplicates?
      The corresponding change to createWindowsDevkit2019.sh looks good:
      https://openjdk.github.io/cr/?repo=jdk&pr=212&range=11#udiff-7

            luhenry Ludovic Henry
            thartmann Tobias Hartmann
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: