While cleaning up the logging in Erik's new code for:
JDK-8253064 monitor list simplifications and getting rid of TSM
I noticed that logging/logStream.hpp includes memory/resourceArea.hpp
but doesn't need it.
That include was added to logging/logStream.hpp by:
JDK-8153659 Create a CHeap backed LogStream class
but logging/logStream.hpp has since evolved to no longer
use ResourceMarks in the header file. Looks like that work
was done via:
JDK-8181917: Refactor UL LogStreams to avoid using resource area
Of course, removing the include of memory/resourceArea.hpp reveals
other code that uses ResourceMark(s), but never bothered to include
memory/resourceArea.hpp.
I created this issue to pull on the sweater threads in order
to clean this up.
Update: It was a sub-task ofJDK-8253064, but, after thinking about it,
I think it makes more sense as a standalone issue.
I noticed that logging/logStream.hpp includes memory/resourceArea.hpp
but doesn't need it.
That include was added to logging/logStream.hpp by:
but logging/logStream.hpp has since evolved to no longer
use ResourceMarks in the header file. Looks like that work
was done via:
Of course, removing the include of memory/resourceArea.hpp reveals
other code that uses ResourceMark(s), but never bothered to include
memory/resourceArea.hpp.
I created this issue to pull on the sweater threads in order
to clean this up.
Update: It was a sub-task of
I think it makes more sense as a standalone issue.
- relates to
-
JDK-8181917 Refactor UL LogStreams to avoid using resource area
- Resolved
-
JDK-8153659 Create a CHeap backed LogStream class
- Resolved
-
JDK-8253064 monitor list simplifications and getting rid of TSM
- Resolved