Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8255579

x86: Use cmpq(Register,Address) in safepoint_poll

    XMLWordPrintable

Details

    • Enhancement
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 16
    • 16
    • hotspot
    • None
    • b23

    Description

      JDK-8253180 added a new block in `safepoint_poll` that uses broken `cmpq` (JDK-8255550): it effectively does the comparison with operands swapped.

      It makes sense to use the non-broken `cmpq`, as to avoid changing the condition code and thus making the code less understandable.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. JDK-8255550 x86: Assembler::cmpq(Address dst, Register src) encoding is incorrect

          • P2 - Crashes, loss of data, severe memory leak.
          • Resolved
          relates to

          Enhancement - null JDK-8253180 ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jdk/4b20e460

          Review Review openjdk/jdk/924

          Activity

            People

              shade Aleksey Shipilev
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: